Several bugs related to precedences graph (2)

[Jerome Legrand]

The precedences graph component edition (add/delete) capabilities should be suppressed in order to limit bugs and make add/update dialog boxes independent from this graph.

These bugs has been found and non resolved in ticket 10 fixes.

Bug 1

"new item" dialog box is modal but does not remain visible if the user click on another Cheddar window.

Bug 2

2 structures (an array and a list) are used to manage item in "dependences graph" dialog box. A variable represents last item added index. When an item is added, this variable is incremented (Ok) but when an item is removed, it is not decremented...

Furthermore, the use of the 2 structures is not clear in the source code...

Bug 3

One can find the following string hard coded : "message", "buffer" and "task"...

Bug 4

When a user add an item, a new_item_object is allocated. If the item creation is canceled, this object is not freed...

Bug 5

When an item is created, its location on the precedences graph is on coordinate (0, 0). It should be located on mouse click coordinate.

Bug 6

When an item is deleted in the "add/update" dialog box, the corresponding graphical representation in the "dependences graph" is deleted as well (should be on close).

If this operation is canceled ("cancel" button), the graphical representation does not reappear and the item has been removed from the internal array, so if one try to remove the same item, Cheddar crashed...

Furthermore, if to many delete operation occur, Cheddar can crash.

Bug 7

After the "Limit creation" test, the project cannot be saved (buffer coordinate pb).

[jerome]

Replying to Jerome Legrand:

When an item is added, this variable is incremented (Ok) but when an item is removed, it is not decremented...

Last_Item is now decremented.

[singhoff]

the dependency window has been deleted to fix this issue